Close #157 Time Step is Iteration

ComputationalRadiationPhysics / libSplash

libSplash - Simple Parallel file output Library for Accumulating Simulation data using Hdf5

GNU Lesser General Public License v3.0

15 stars 15 forks source link

Close #157 Time Step is Iteration #186

Closed PrometheusPi closed 9 years ago

PrometheusPi commented 9 years ago

This pull request solves issue #157. The usage of timestep or time or similar is avoided and replaced by iteration or similar.

ax3l commented 9 years ago

thank you for the PR, but let me re-open this issue since I basically want to change 80% of the lines that your sed script replaced ;)

iteration step is doubled, just iteration
scripts and xdmf actually use key-words in xml, you can not replace those (splash2xdmf is now broken)
splash2xdmf.py needs cross check which hooks are used in pic2xdmf.py and if they still work after re-naming

PrometheusPi commented 9 years ago

@ax3l OK - I expected this for the first iteration. I will discuss it with you in person today morning (when it is not in the middle of the night) and clarify some of the points mentionen in #157. :jetlag_smiley: