Fix comparison and docu of generateCollectionType

ComputationalRadiationPhysics / libSplash

libSplash - Simple Parallel file output Library for Accumulating Simulation data using Hdf5

GNU Lesser General Public License v3.0

15 stars 15 forks source link

Fix comparison and docu of generateCollectionType #240

Closed Flamefire closed 8 years ago

Flamefire commented 8 years ago

The function returns ColTypeUnknown on not-found. Also the typeid check is superfluous as the static function genType of that type should per definition return an instance of itself. An assertion is added instead.

In case new genType's are implemented, this will guarantee that no mem-leaks can appear.

ax3l commented 8 years ago

@slizzered do you mind taking a look, too? :)

ax3l commented 8 years ago

please make your PR to dev!