ComputationalRadiationPhysics / libSplash

libSplash - Simple Parallel file output Library for Accumulating Simulation data using Hdf5
GNU Lesser General Public License v3.0
15 stars 15 forks source link

DataContainer reads wrong offset #254

Closed ax3l closed 6 years ago

ax3l commented 7 years ago

When reading a domain with DomainCollectors putting the result via addDomain to a DataContainer the offset in the container is determined falsely (always 0,0,0).

logic error in libSplash when reading offsets:

Related to https://github.com/ComputationalRadiationPhysics/picongpu/issues/1544

Flamefire commented 7 years ago

Idea for a fix: If the first entry is added then init offset to the entrys offset. Would only be 2 lines added.

ax3l commented 7 years ago

that could work, but I did not check the full logics it will touch yet.

maybe we add a (currently failing) test first and then implement that by checking subdomains.size() for the first add?