search

ComputationalRadiationPhysics / libSplash

libSplash - Simple Parallel file output Library for Accumulating Simulation data using Hdf5
GNU Lesser General Public License v3.0
15 stars 15 forks source link

Keep info on H5 datatypes in collection types #259

Closed Flamefire closed 7 years ago

Flamefire commented 7 years ago

Found this branch that is still not in any PR.

This keeps the actual collection type for strings and removes some entanglements of ColTypeDim with Dimensions. The former is the most important part as it allows meaningful isNullTerminated and isVariableLength queries. Without keeping the original H5 types this would return the wrong results.

ax3l commented 7 years ago

@Flamefire rebase against dev should fix the travis environment (but not your compile bug)

Flamefire commented 7 years ago

Here again I think there is a serious problem in libSplash as there seem to be random errors which sounds like race conditions to me. There is one failed test for the "Fix compile errors" commit with a assertion failed - Expression: sum == old_sum in only one compilation but it is gone in the next commit which did not change anything at all (just re-added a function but did not use it)

ax3l commented 7 years ago

is this still an issue? did you try running valgrind on it?

Flamefire commented 7 years ago

It is not an issue of this PR, it can be merged without changing this. Just wanted to point out that libsplash might have a serious problem

ax3l commented 7 years ago

Can you please put the issue in a separate issue and describe when it appears so one has at least a chance how to reproduce it? :D

Flamefire commented 7 years ago

--> #262 Sorry, can't give more detail as it occurs rarely.