ComputationalRadiationPhysics / libSplash

libSplash - Simple Parallel file output Library for Accumulating Simulation data using Hdf5
GNU Lesser General Public License v3.0
15 stars 15 forks source link

FindHDF5: Use Upstream CMake Version #267

Closed ax3l closed 6 years ago

ax3l commented 6 years ago

Since CMake 3.3.0+ the VERSION is supported in upstream FindHDF5.cmake

Our self-made module was introduced in #176 and is too cumbersome to maintain. Also, supporting CMake 2.X is not a sane idea anymore.

Related to https://github.com/ComputationalRadiationPhysics/picongpu/issues/2369#issuecomment-342814749

Note: We might need CMake 3.10.0+

-> CMake 3.6-3.9 contains broken FindHDF5 scripts, will update the CMake requirement before the next release

psychocoderHPC commented 6 years ago

Due to the bug in CMake <3.10.0 is it useful to merge this PR?

ax3l commented 6 years ago

I think only CMake 3.6-3.9 contains broken FindHDF5 scripts ;)