search

ComputationalRadiationPhysics / libSplash

libSplash - Simple Parallel file output Library for Accumulating Simulation data using Hdf5
GNU Lesser General Public License v3.0
15 stars 15 forks source link

potential memory leak #278

Closed psychocoderHPC closed 6 years ago

psychocoderHPC commented 6 years ago

The method generateCollectionType() used in getType() is returning a pointer those must be freed by the caller. Due to the reason that getType is returning a reference this is not obvious for the caller.

psychocoderHPC commented 6 years ago

Wrong alarm the memory is freed in the destructor https://github.com/ComputationalRadiationPhysics/libSplash/blob/140d6ce903d265909c3f8021d5d9cc04e5a72d37/src/AttributeInfo.cpp#L42