ComputationalRadiationPhysics / libSplash

libSplash - Simple Parallel file output Library for Accumulating Simulation data using Hdf5
GNU Lesser General Public License v3.0
15 stars 15 forks source link

CMake: Honor _ROOT Env Hints #281

Closed ax3l closed 5 years ago

ax3l commented 5 years ago

CMake 3.12.0+ honor <Package>_ROOT environment hints which are often set on HPC systems. Previously, it was only looking for <Package>_DIR paths in find_package calls.

This new policy is useful since HPC systems usually set _DIR, _ROOT or expand the CMAKE_PREFIX_PATH. Therefore we want to use it as soon as it is available.

On systems where those env vars are set, e.g. Hypnos, this also throws a warning if the default (OLD) policy is used with CMake 3.12.4 or newer.

References:

psychocoderHPC commented 5 years ago

@ax3l is this policy than automatically set in the generated cmake file out of SplashConfig.cmake.in?

ax3l commented 5 years ago

@psychocoderHPC I think yes, but didn't verify. At least I didn't see anything like this in ADIOS2, which is my usual reference for modern CMake ;-)

https://github.com/ornladios/ADIOS2/search?q=CMP0074&unscoped_q=CMP0074

ax3l commented 5 years ago

I fixed the CI in #282, so this should run successfully now.

ax3l commented 5 years ago

@psychocoderHPC ready for merge :)

ax3l commented 5 years ago

ping @psychocoderHPC