We currently (1.7.0) link in CMakeLists.txt to ZLIB::ZLIB, although we do not include zlib directly in Splash.
This dependency should nowadays (recent CMake versions such as our 3.10+) be properly be pulled by the HDF5 CMake target.
Currently, we request zlib again and forget to search it in SplashConfig.cmake, which leads to the downstream issue of injecting a ZLIB::ZLIB in Splash::Splash yet not looking for a target. Therefore, users have to perform
find_package(ZLIB REQUIRED)
# just to get the ZLIB::ZLIB target into scope
# otherwise `Splash::Splash` below tries to link `-lZLIB::ZLIB`
find_package(Splash REQUIRED)
target_link_libraries(myTarget PRIVATE Splash::Splash)
We currently (1.7.0) link in
CMakeLists.txttoZLIB::ZLIB, although we do not include zlib directly in Splash.This dependency should nowadays (recent CMake versions such as our 3.10+) be properly be pulled by the HDF5 CMake target.
Currently, we request zlib again and forget to search it in
SplashConfig.cmake, which leads to the downstream issue of injecting aZLIB::ZLIBinSplash::Splashyet not looking for a target. Therefore, users have to perform