search

ComputationalRadiationPhysics / picongpu

Performance-Portable Particle-in-Cell Simulations for the Exascale Era :sparkles:
https://picongpu.readthedocs.io
Other
690 stars 217 forks source link

libPMacc::GridController init tmp var declaration #1167

Open erikzenker opened 8 years ago

erikzenker commented 8 years ago

Using variable name tmp says nothing about the content of a variable:

DataSpace<DIM3> tmp;
DataSpace<DIM3> periodicTmp;

Found here. What about nodesDIM3 and periodicDIM3 ?

ax3l commented 8 years ago

@psychocoderHPC pls have a look :)

psychocoderHPC commented 8 years ago

Yes the naming is bad please contact Wolfgang Hoenig ^^

We should change the bad names