ComputationalRadiationPhysics / picongpu

Performance-Portable Particle-in-Cell Simulations for the Exascale Era :sparkles:
https://picongpu.readthedocs.io
Other
703 stars 217 forks source link

Synchrotron radiation plugin: Operations out of range #5036

Closed steindev closed 1 month ago

steindev commented 2 months ago

Hey, when compiling a simple setup using the standard speciesXXX.param files I receive the following warnigs:

include/picongpu/../picongpu/particles/synchrotron/AlgorithmSynchrotron.hpp(178): warning #222-D: floating-point operation result is out of range
                          * (ELECTRON_CHARGE * ELECTRON_CHARGE * ELECTRON_MASS * SPEED_OF_LIGHT
                                                               ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

include/picongpu/../picongpu/particles/synchrotron/AlgorithmSynchrotron.hpp(179): warning #222-D: floating-point operation result is out of range
                             / (HBAR * HBAR * EPS0 * 4._X * PI));

cc @FilipO28555

finnolec commented 2 months ago

I'm running into the same warnings when I compile a simulation with millimeter-cell sizes

steindev commented 2 months ago

I'm running into the same warnings when I compile a simulation with millimeter-cell sizes

This is also the situation I have.

BrianMarre commented 2 months ago

@finnolec and @steindev Just because I am paranoid what value does TYPICAL_PARTICLES_PER_MACROPARTICLE have in your setups?

is set in unit.param by default depending on TYPICAL_PPC and BASE_DENSITY from density.param and particle.param respectively

finnolec commented 2 months ago

We're using the default BASE_DENSITY_SI = 1.e25 and TYPICAL_PARTICLES_PER_CELL = 2u but we both have vacuum simulation boxes. The solution would probably be to manually adapt the unit.param to use sane defaults... if you would ever use the synchrotron plugin with millimeter cell sizes in vacuum

finnolec commented 2 months ago

Maybe the plugin does not need to be compiled without synchrotron particles

psychocoderHPC commented 1 month ago

The error still exists, can someone please have a look into it.

psychocoderHPC commented 1 month ago

should be fixed by #5069