fix warning in PyPIConGPU version tests

ComputationalRadiationPhysics / picongpu

Performance-Portable Particle-in-Cell Simulations for the Exascale Era :sparkles:

https://picongpu.readthedocs.io

Other

709 stars 218 forks source link

Closed SimeonEhrig closed 2 months ago

SimeonEhrig commented 2 months ago

If the script requirements_txt_modifier.py should modify a dependency in a requirements.txt, which does not exist, it throws a warning because this is unexpected behavior. Because warnings are hard to detect in the CI, change it to an error.
Implement a function to ignore specific environment variables which are set to change the version in a requirements.txt.

SimeonEhrig commented 2 months ago

@BrianMarre please review

psychocoderHPC commented 2 months ago

@SimeonEhrig Does it mean the test you pointed to will now fail with this PR?

SimeonEhrig commented 2 months ago

The PR also contains the fix for the current setup. But in future, if the setup will be changed, hopefully yes.

SimeonEhrig commented 2 months ago

I didn't fixed the comments. I pushed again to trigger the CI to see, if the script is called somewhere else. I will fix the issues later.

SimeonEhrig commented 2 months ago

@chillenzer Can you check it again. I think now it looks much better.

SimeonEhrig commented 2 months ago

ping @chillenzer