ComputationalRadiationPhysics / picongpu

Performance-Portable Particle-in-Cell Simulations for the Exascale Era :sparkles:
https://picongpu.readthedocs.io
Other
710 stars 218 forks source link

Disable field ionization in the atomicPhysics test case #5175

Closed ikbuibui closed 1 month ago

ikbuibui commented 1 month ago

Change needed to do the scaling tests with the atomicPhysics test case for JUREAP

psychocoderHPC commented 1 month ago

This PR breaks the dev branch, please fix

required from here

942/builds/hzdr/crp/picongpu/include/picongpu/../picongpu/particles/atomicPhysics/kernel/FillLocalRateCache_BoundFree.kernel:348:35: error: parameter 'eFieldBox' set but not used [-Werror=unused-but-set-parameter]

943 348 | T_EFieldDataBox const eFieldBox,

944 | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~

945cc1plus: all warnings being treated as errors

Am 18. Oktober 2024 10:06:14 MESZ schrieb Tapish Narwal @.***>:

You can view, comment on, or merge this pull request online at:

https://github.com/ComputationalRadiationPhysics/picongpu/pull/5175

-- Commit Summary --

  • Disable field ionization in the atomicPhysics test case

-- File Changes --

M share/picongpu/examples/AtomicPhysics/include/picongpu/param/atomicPhysics.param (2)

-- Patch Links --

https://github.com/ComputationalRadiationPhysics/picongpu/pull/5175.patch https://github.com/ComputationalRadiationPhysics/picongpu/pull/5175.diff

-- Reply to this email directly or view it on GitHub: https://github.com/ComputationalRadiationPhysics/picongpu/pull/5175 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

chillenzer commented 1 month ago

Ah, @ikbuibui added CI:no-compile. So, that's why that didn't pop up. But, of course, the mistake was already in the code, just not compiled in the previous example. I'm on it.

chillenzer commented 1 month ago

See #5181.