Closed ikbuibui closed 9 months ago
std::shared_mutex
is available from c++17 onwards. The alias was a workaround to get it in c++14 and can simply be removed when transisioning to c++17. I didnt want to write std::shared_timed_mutex
since its not about timeouts, which the name implies but read/write-lock.
std::shared_mutex
is available from c++17 onwards. The alias was a workaround to get it in c++14 and can simply be removed when transisioning to c++17. I didnt want to writestd::shared_timed_mutex
since its not about timeouts, which the name implies but read/write-lock.
Noted. Thank you, I will update to use std::shared_mutex
instead, along with a bump to c++17
RedGrapes was redefining
shared_mutex
as an alias ofshared_timed_mutex
in thestd
namespace, which was causing compile errors when used with alpaka. In general this extension of std is at best undefined behavior and shouldn't be done. This PR fixes this by explicitly callingstd::shared_timed_mutex
in redGrapes. Alternatively it is possible to do this alias in namespace redgrapes instead of pulling it into std, but especially with only a few places wherestd::shared_timed_mutex
is used, this way seems more clear.