ComputationalRadiationPhysics / student_project_python_bindings

The student project investigates the performance and memory handling of Python bindings for CUDA C++ code created with pybind11.
GNU General Public License v3.0
1 stars 0 forks source link

Overwork CMake of the Phase Retrieval Class implementation #22

Closed SimeonEhrig closed 3 years ago

SimeonEhrig commented 3 years ago
SimeonEhrig commented 3 years ago

@afif-ishamsyah Can you please test it on windows. In special this change: https://github.com/ComputationalRadiationPhysics/student_project_python_bindings/blob/01223e083d2cd699182aa0dad4230a7b66bb1cd8/cuda_phase-retrieval_class/cmake/add_msvc_poperties.cmake#L8-L15

afif-ishamsyah commented 3 years ago

I need to uncomment that whole part in windows because the example files was not exist in "src" folder. But other than that everything is fine.

I will merge it with the target branch and will fix this alongside other imporvements