ComputationalScienceLaboratory / ODE-Test-Problems

A MATLAB suite of initial value problems
https://computationalsciencelaboratory.github.io/ODE-Test-Problems/
MIT License
9 stars 2 forks source link

problem.solve does not support alternate RHS #59

Closed AndreyAPopov closed 1 year ago

AndreyAPopov commented 1 year ago

Title. It would help a lot with testing if this was possible.

Steven-Roberts commented 1 year ago

Hmm, I wish we could move solve functionality into RHS but it needs access to the Problem for events. What is the use case? Testing the alternate QG RHS? Anything else?

Steven-Roberts commented 1 year ago

Events make it tricky to switch out an RHS because the problem can change. https://github.com/ComputationalScienceLaboratory/ODE-Test-Problems/blob/c9ec2386d25f9bccac84f1d70bb32fdef755bc4f/src/%2Botp/Problem.m#L243 I think we would have to specify the alternate RHS as a string representing the name of a Problem property. Not a big fan of that solution...

Steven-Roberts commented 1 year ago

Closing for lack of clean solution. We'll just have to make separate tests for problems with extra RHS'