search

ComputeCanada / puppet-jupyterhub

Puppet module to deploy a JupyterHub that submits job to Slurm
MIT License
11 stars 7 forks source link

Apply export values from hieradata to submit.sh.epp template #42

Closed Takadonet closed 1 year ago

Takadonet commented 1 year ago

Would be great that in hieradata that we can specific more information to be added to submit.sh.epp . We have a few bash export variables that I wish to add that currently not set in template.

Do not want to fork off the repo for a single change since it be more difficult to get changes in the future.

Suggestion that it generic that you can one or more export variables. Example below hieradata:

jupyterhub::submit::export: 
  variable_name_1: "value 1"
  variable_name_2: "value 2"

I can make a PR if you are receptive to the suggestion.