search

ComputeCanada / software-stack-config

8 stars 3 forks source link

Warning no version #55

Open mboisson opened 1 year ago

mboisson commented 1 year ago

This pull request is a proposal to address https://github.com/ComputeCanada/software-stack/issues/122

mboisson commented 1 year ago

The relevant commit really is this one: https://github.com/ComputeCanada/software-stack-config/pull/55/commits/cc364801d4054a769cc7e9e2b703aa28b4c2a8f6

ofisette commented 1 year ago

The code looks fine but I have reservations about the digit-based approach. Some packages (e.g. GROMACS) have versions with an inconsistent the number of components/digits (e.g. 2023 and 2023.1 but no 2023.0), others have date-based versions (e.g. LAMMPS 20220623) where “one digit” is a bit unclear (it could be misunderstood to mean “2” rather than “20220623”).

I think it would be better to special-case individual packages for which we want a different message. Or, make two lists: packages that follow semantic versioning (e.g. Python, Arrow) and those that do not. Packages that follow semver are the only ones for which I think it is helpful to not use a full version number (and the right number of components/digits for semver-following packages is always 2, major.minor).