search

ComputeCanada / wheels_builder

10 stars 2 forks source link

rely on python-build-bundle rather than installing pip, setuptools, w… #79

Closed mboisson closed 1 year ago

mboisson commented 1 year ago

…heel, stuptools_scm[toml]

pour le main

ccoulombe commented 1 year ago

I've encountered some packages needing the latest of cython. I think we should not pin the version, and still use the cython wheel and not the module for this. Likewise for pybind11.

On the other side, the vast majority would work with these, and we can override the version in the config file for the ones that doesn't.

mboisson commented 1 year ago

pybind11 is included in python-build-bundle, which we already load, and we can always upgrade those versions in the future (and the current cython module is actually the latest)

mboisson commented 1 year ago

Also, I would argue that if some packages require a more recent version, it should be a dependency for that package (it's always possible to install different versions in the build environment)

ccoulombe commented 1 year ago

Yes, for now. Also yes :)