search

Computer-Vision-in-the-Wild / DataDownload

MIT License
24 stars 4 forks source link

Environment for data downloading #1

Closed JegZheng closed 2 years ago

JegZheng commented 2 years ago

Hi,

Thanks for the great work. When downloading the image classification datasets, I encountered the following error:

Traceback (most recent call last): File "download_datasets.py", line 18, in hub = DatasetHub(pathlib.Path('./resources/vision_datasets.json').read_text()) File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/vision_datasets/resources/dataset_hub.py", line 25, in init self.dataset_registry = DatasetRegistry(dataset_json_str) File "/anaconda/envs/azureml_py38/lib/python3.8/site-packages/vision_datasets/common/dataset_registry.py", line 12, in init self.datasets = [DatasetInfoFactory.create(d) for d in json.loads(datasets_json)] File "/anaconda/envs/azureml_py38/lib/python3.8/json/init.py", line 357, in loads return _default_decoder.decode(s) File "/anaconda/envs/azureml_py38/lib/python3.8/json/decoder.py", line 337, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/anaconda/envs/azureml_py38/lib/python3.8/json/decoder.py", line 355, in raw_decode raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 559 column 1 (char 17335)

I think this error is raised by the incompatibility of the package version. I am using Pytorch==1.8.1, and vision_datasets==0.2.12. Could you please list the correct package version in the README? Thanks!

haotian-liu commented 2 years ago

The only package requirement for downloading the classification datasets is vision-datasets>=0.2.0. The error above now been fixed by updating the JSON file in the repo, and thanks for pointing this out!

Please use the latest code base to download the datasets. Thank you!

JegZheng commented 2 years ago

The only package requirement for downloading the classification datasets is vision-datasets>=0.2.0. The error above now been fixed by updating the JSON file in the repo, and thanks for pointing this out!

Please use the latest code base to download the datasets. Thank you!

Thanks! This addresses my issue well. BTW the json file in the Elevater_Toolkit_IC repo might need also this update.

haotian-liu commented 2 years ago

Thanks for the kind reminder! It has now been updated as well.