Closed olaure01 closed 3 years ago
What should be looked at for this PR I think is:
What should be looked at for this PR I think is:
- should a second permutation be added on the json/rule-request side, and how?
- how is the second permutation updated by the user doing drag&drops inside the ongoing proof?
I'm on it. A commit is coming soon.
Implicit exchange should work on preprod except if proof starts with an exchange (cf. comment above). May I activate it (with Proof.to_latex (Some None)
)?
Once the code is correct, we could start testing things on pre-prod by using Proof.to_latex None
for LaTeX export and Proof.to_latex (Some None)
for png export (no opinion for pdf).
In a second step this could become an option giving an uniform result for all three exports.
Once the code is correct, we could start testing things on pre-prod by using
Proof.to_latex None
for LaTeX export andProof.to_latex (Some None)
for png export (no opinion for pdf). In a second step this could become an option giving an uniform result for all three exports.
On preprod:
There is something to decide regarding the concluding sequent when it has been permuted and thus is different from the original submitted one:
I would say, always keeping the original sequent is more general. @etiennecallies do you have a more definite opinion?
I like the idea of snapshot. It is simple to understand.
Why would the user have changed the concluding sequent?
OK for me. Should we then apply the same reasoning to explicit exchange export?
There is some exchange simplification to do (I did not really investigate the cause):
A*A^,A|A^
: auto-prove, then permute conclusions then pdf export: useless concluding identity exchange rule.
I would say:
It's what should be deployed on preprod. It seems natural to me. But I'm very opened to alternatives.
It looks good to me.
I merge this, and will add the UI option (explicit/implicit) in another PR. Thanks
Extend the exchange rule with an additional permutation which can be used to encode the current state on screen and relied on for export with an implicit exchange rule. LaTeX export is extended with an implicit exchange version.