I'm seeing some favicons not being processed due to an EndOfStreamException. Specifically, the following line in HttpSource.cs ExtractIcoSizes where it attempts to read the ICO header seems to be the culprit:
stream.Seek(4000, SeekOrigin.Begin);
var count = reader.ReadInt16();
According to FileFormat.com the total number of images in the ICO file starts at the 4th byte offset, not the 4000th. I'm not sure if I'm missing something or if this is a legitimate mistake, but when I change the line to be:
stream.Seek(4, SeekOrigin.Begin);
var count = reader.ReadInt16();
I seem to get much better and more consistent results. Will submit a pull request for this change in case you want to merge it.
I'm seeing some favicons not being processed due to an EndOfStreamException. Specifically, the following line in HttpSource.cs ExtractIcoSizes where it attempts to read the ICO header seems to be the culprit:
According to FileFormat.com the total number of images in the ICO file starts at the 4th byte offset, not the 4000th. I'm not sure if I'm missing something or if this is a legitimate mistake, but when I change the line to be:
I seem to get much better and more consistent results. Will submit a pull request for this change in case you want to merge it.