search

ComputerGhost / FaviconFetcher

Scan a webpage for favicons, or just easily download the one you want.
MIT License
5 stars 3 forks source link

WebRequest is deprecated #16

Open kiddailey opened 1 year ago

kiddailey commented 1 year ago

WebRequest is used for all requests but that particular method has been deprecated and Microsoft recommends migrating to HttpClient instead. As HttpClient is async, this also relates to issue #14.

ComputerGhost commented 1 year ago

WebRequest is used to allow cache sharing with other applications such as IE. I agree that it needs replaced, but I'm putting this off for a major version upgrade since it removes an advertised feature.

kiddailey commented 5 months ago

Ah, I see. I'm probably going to have to maintain my own version then as using WebRequest doesn't appear to be 100% cross-platform anymore. Specifically, I'm seeing some WebRequests on iOS and Android fail for unknown reasons. I have a working async version using HttpClient implemented and in testing that resolves those issues on all platforms.