Open zhuxb711 opened 5 months ago
Nice catch, thank you! Would it be simpler to just properly dispose the SKBitmap properly?
Returning a copy of the bitmap could increase memory usage if I'm understanding correctly.
Yes sure, just dispose the underlying _bitmap is ok for this case. SKBitmap should be disposed when IconImage disposing
Just set _bitmap into null
https://github.com/ComputerGhost/FaviconFetcher/blob/4d02448fe04ef64a7a72f4a00340bda049ed0b96/FaviconFetcher/Classes/IconImage.cs#L72
If concerning dispose the _bitmap will affect
ToSKBitmap()
. I suggest to changeToSKBitmap()
to:or