search

ComputerGhost / FaviconFetcher

Scan a webpage for favicons, or just easily download the one you want.
MIT License
5 stars 3 forks source link

Missing icon #5

Closed timeshift79 closed 2 years ago

timeshift79 commented 2 years ago

Not able to get favicon from the following site:

https://ice-sentralbord.ice.no/

I collects the favicon with the scanner, but it doesn't extract the link:

image

The url for the favicon is "https://sentralbord.ice.no/app/res/favicon.ico", but the scanner finds "https://ice-sentralbord.ice.no/res/favicon.ico".

ComputerGhost commented 2 years ago

Problem fixed in latest version 1.3.0. Now the base tag is supported, which fixes the favicon url for your example.

timeshift79 commented 2 years ago

Thanks, but did you break support for .net framework?

image

ComputerGhost commented 2 years ago

Thanks for pointing this out! It should be fixed now, version 1.3.1. I added support back for netstandard2.0.

timeshift79 commented 2 years ago

Thanks, working again now. Another small issue that appeared is that if you fetch the closest:

var image = fetcher.FetchClosest(uri, new Size(48, 48));

It doesn't return any image, even though it finds one with the scanner. The logic of the function should be that it fetches the closest, and if the closest is eg 16x16 or anything else, it should return that. For the above mentioned link it doesn't return anything using the FetchClosest.

timeshift79 commented 2 years ago

It still doesn't get the correct url if you try the first link i posted in this issue.

ComputerGhost commented 2 years ago

I'll make a new issue later for the fetcher not pulling it down. The original issue was because the "base" tag was being ignored. Adding support for that fixed the scanner URLs. This new problem with the fetcher is caused by a 'text/html' content type being used for the icon.