search

ComputerGhost / FaviconFetcher

Scan a webpage for favicons, or just easily download the one you want.
MIT License
5 stars 3 forks source link

Convert into a Portable Class Library #8

Closed kiddailey closed 1 year ago

kiddailey commented 2 years ago

Was hoping to use this in a PCL that will compile on Windows, MacOS, iOS and Android, but it doesn't appear that this is compatible. Would be nice if it could be adjusted to do so -- though I realize that some functionality may not be possible in those environments.

For what it's worth, it could simply be the use of System.Drawing that is the issue. I can't recall at the moment. I'll integrate it into my tests again and update this issue with the specific error information when I can.

Edit: Yes, as I suspected, System.Drawing is the culprit as it is not supported in Xamarin.

kiddailey commented 1 year ago

I've since modified the code to use SkiaSharp instead of System.Drawing and it seems to work well. Will create a Fork and/or Pull Request if anyone is interested.

kiddailey commented 1 year ago

I've submitted a pull request #9 implementing the changes to replace System.Drawing with SkiaSharp.