ComputerMaster1st / Railgun

Railgun Re-written w/ C# + Entity Framework
11 stars 2 forks source link

feature request: add the hability to set a default railguns music volume #53

Open sanslash332 opened 3 years ago

sanslash332 commented 3 years ago

Hello guys!

First of all thanks for this awesome bot!

So, is possible add a command to set a default playing volume for the music?

We have a server for blind people, and everione loves railgun; but the problem is when someone new joins to the server, and don't set manually the volume for railguns, at 100% is anoying for us, because is lowder than the screen readers. So is a big deal stop the music, explain to the new comers how to set the bot's volume, and set it again.

So is possible work in a feature like this? IS if possible thanks!

ComputerMaster1st commented 3 years ago

Hi There,

I'm really happy that you like the bot! 😄

I'm afraid there's a problem with adding a command related volume control. The issue is we use opus more directly and not use FFMPEG (which could give us volume control). We chose to use opus due it being lighter on system resources and saves us from spending more CPU on encoding. Especially with the bot constantly growing the way it is.

We've been asked about volume control before and the answer's still the same at this time sadly. We'd like to implement something like this if we're able to. However, we don't know how to change volume with opus encoded audio at the moment and I don't know if we ever will. Sorry about this.

The only solution I can suggest for those with accessibility issues is to tell them to set the user volume to 5-10% before joining the voice channel. I don't have any other solutions at this time until we've figured out how to change the volume for opus encoded audio which of-course may require us to completely reverse engineer it.

My apologies again for not being able to provide anything better. 😞

EDIT: I'll ask my friend who helps with audio management to see if they can figure something out. However, there's no guarantee's we'll find a solution.

sanslash332 commented 3 years ago

Hello @ComputerMaster1st Wow, thanks for your fast answer! thanks for check this request!

So, but is possible attack the problem from other edge?

In the discord client (I don't know if is possible through the api) you can control your own input and output volume. You don't have that control through the api?

Or the discord api is agnostic about that and only receive a audio stream and is deal of your software control the volume of the audio?

Buts well; again, thanks for the answer, and thanks for do this amazing bot.

:)