search

ComputerScienceHouse / bingehack

A fork of nethack with semi-multiplayer features and other customizations. (An in-heavy-development fork version is at https://github.com/computersciencehouse/bingehack4 )
http://nethack.csh.rit.edu
23 stars 4 forks source link

Bottom line loses coloring #41

Closed eatnumber1 closed 14 years ago

eatnumber1 commented 14 years ago

When nethack starts, the bottom line is not colored (statuscolors). It does not become colored until the user presses a key.

alliekins commented 14 years ago

The bottom line also loses color when popping out of certain menus (like Options) until you press a key.

clockfort commented 14 years ago

also happens during ynq() prompt

eatnumber1 commented 14 years ago

Fixed. See SHA: c8f2191d0b4ede62a11fdf4a479c2d9054e5e1b9. Clockfort, can you see any reason why the original authors of the statuscolors patch saved and restored flags.botlx?

clockfort commented 14 years ago

flags.botlx is just a boolean that forces the game to completely redraw the status lines at the bottom. The patch actually sets this to zero halfway through its code before restoring to whatever value was there before.

I think this might have mattered in an older version of the code, perhaps. I could see edge cases occurring, for instance, if flags.botl (partial redraw of status lines) and flags.botlx (full redraw of status lines) where both 1, and if statuscolors had reset the botlx flag to zero in the middle of its code in bot2(), like it currently does, its possible that the full redraw would never have been triggered.

Anyway, looks like the only place bot2() is called is in bot(), which does a full draw of the status line by calling bot1(), bot2() and then resetting both flags, so it looks pretty safe.

It looks like all of the partial status line redraw code is no longer in nethack, as the code in the many places I looked seems to just say "ah, screw it, if either the full or partial status line redraw flags are set, just redraw the whole status line".

tl;dr: I think we'll be fine.