search

ComputerScienceHouse / letmein2

A second wack at LetMeIn. It came to me in a dream!
MIT License
6 stars 5 forks source link

Fix async or whatever on the Client #28

Closed WillNilges closed 2 years ago

WillNilges commented 2 years ago

Yea, I upgraded CircuitPython and basically re-wrote the whole thing. It... kinda works.

WillNilges commented 2 years ago

wtf why did I just see it get an l_well nvm when I asked for a n_stairs nvm

WillNilges commented 2 years ago

Oh, it's the guest sending that.... wtf?

The client is caught by the music loop and misses it. This is because they're running in the same "Task."

WillNilges commented 2 years ago

Christ I'm gonna need to update the README again lol

WillNilges commented 2 years ago

I noticed that when you make multiple requests, sometimes it takes a sec for the subsequent requests to work. Sometimes they don't work at all.

Looked at the logs, and it seems like there's some websocket stuff that's happening that shouldn't be.

Maybe I should make sure the websocket is closed under all circumstances.

Also I should handle websocket-related errors (like the socket being closed) and report them to the user

Also I should fix the awkward-as-all-hell way that I pass the websocket and mqttclient to the functions in the server. Those should definitely be in an object. I think trying to combine the actual "Event" object with the "Message" object was a mistake, and I should fix it.

Also I should fix the global variable bullshit that's happening on the Client.

WillNilges commented 2 years ago

Hmm the client isn't taking the "cancel" properly....

WillNilges commented 2 years ago

It's a bit flaky. Seems like it might actually be an issue on the Guest (aforementioned websocket nonsense)

WillNilges commented 2 years ago

Bro there are so many issues that I need to create after this.

Now I want to move the jingles into a file of some kind.

WillNilges commented 2 years ago

lol I also need to fix the case when people leave their name blank. I think I want to yell at them if that happens...

WillNilges commented 2 years ago

Ah fuck I still have to re-implement the silence feature

WillNilges commented 2 years ago

It would also be cool if the guest interface would display the devices currently alive/muted/dead.

WillNilges commented 2 years ago

Just witnessed the stupid fucking thing loop through a jingle multiple times, WHILE acknowledging a NVM message, and just... not stopping the playback. Somehow, NVM's are lower priority. Sort of makes sense, because you need the MQTT loop to work, but like, it GOT the thing, and it still kept playing...

WillNilges commented 2 years ago

hmm. It seems to happen for l_well, but not for Level 1 Elevator lobby...

WillNilges commented 2 years ago

Oh I should add an @here to the message so people get pinged. Maybe also a few emojis to make it pop. I wish I could change the background color or something.

WillNilges commented 2 years ago

Perhaps a picture? IDK these comments are not relevant to this PR, I'm just lazy.

WillNilges commented 2 years ago

Shit I need to update the library documentation and also document the Jingles.

Maybe move them into another folder too