ComputerScienceHouse / packet

Web packet written in Python for Computer Science House
MIT License
23 stars 26 forks source link

Prevent "testing" user from being on packet #365

Open jabbate19 opened 1 year ago

jabbate19 commented 1 year ago

Add some check when populating signatures_upper to prevent adding the user testing so that we don't have to keep deleting it.

mxmeinhold commented 11 months ago

We pull all the upperclassmen at a couple of points. One is when creating new packets, another is in sync_with_ldap. Both of these rely on get_active_members

There are a few cases where the testing user can be useful to have around, such as in dev or staging, but these aren't super important. The simplest solution I think would be to exclude the testing user from the ldap responses entirely. A slightly more complex solution that would still allow for testing would be to exclude the testing user only when deployed in production. This could be something handled by an environment/config variable, or it could be something we change in the actual image build. Lots of options!