Fixed ratemyprofessor link

ComputerScienceHouse / schedulemaker

A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.

http://schedule.csh.rit.edu

GNU General Public License v2.0

62 stars 38 forks source link

Fixed ratemyprofessor link #334

Closed esoccoli closed 10 months ago

jabbate19 commented 11 months ago

Fixes #324

nsp7786 commented 11 months ago

The edit you made doesn't actually change anything, the backend supporting that link format has been deprecated.

Based on #324 , you'd want a link like this: https://www.ratemyprofessors.com/search/professors?q=${name}&sid=${schoolId} (RIT's school id is U2Nob29sLTgwNw==)

MoralCode commented 10 months ago

As the author of #324 (and https://github.com/CalvinWu4/RIT-Rate-My-Professors-Extension/pull/4). It looks like the line under review above should be curl_setopt($curl, CURLOPT_URL, "https://www.ratemyprofessors.com/search/professors?q=" . $name . "&sid=U2Nob29sLTgwNw==");

Would be awesome to see this get fixed in ScheduleMaker!

Mstrodl commented 10 months ago

Obsolete, and wasn't the right file anyways.

MoralCode commented 10 months ago

ah cool, thanks for fixing this! (commit: https://github.com/ComputerScienceHouse/schedulemaker/commit/77ad61b183ad700c95f511cf96d6954af89b478c for anyone looking to see how it was done)