search

ComputerScienceHouse / schedulemaker

A course database lookup tool and schedule building web application for use at Rochester Institute of Technology.
http://schedule.csh.rit.edu
GNU General Public License v2.0
62 stars 38 forks source link

Generate one ical event for meetings instead of one per weekday #339

Closed natep-tech closed 10 months ago

natep-tech commented 11 months ago

Updated the generateIcal() function. (Breaking out the multiple changes from #325 into separate PRs for clarity)

Added code that'll generate a single series for a multi-day course (Mon,Web,Fri for example) to simplify calendars (see the iCal specification for RRULE). If any details are different between the different times (different location or times, for example) it'll fallback to the old code that makes separate series for each listed time in the course. #63

Mstrodl commented 11 months ago

Please fix merge conflicts

natep-tech commented 11 months ago

Merge conflicts should be resolved now.

Mstrodl commented 11 months ago

Hm. The diff still doesn't look right. Try rebasing against develop?

natep-tech commented 10 months ago

I ran a rebase again, hopefully that fixes everything

natep-tech commented 10 months ago

I apologize for the trouble with this PR. Thank you for your patience, the two comments you left should have been resolved by my latest commit.

I'm doing another quality review tonight to ensure the rest of the file is up to snuff.

Mstrodl commented 10 months ago

superseded by #343