Computerization / Enspire

Make "Creativity, Activity, Service (CAS)" Great Again at SWFLA
https://enspire.one
MIT License
5 stars 7 forks source link

fix(eslint): resolve multiple eslint errors #637

Open at-wr opened 1 month ago

at-wr commented 1 month ago

Fixed errors

Pre-Fix error

Link: https://github.com/Computerization/Enspire/pull/636/checks

/pages/manage/manage.vue
Error:   36:10  error  'error' is defined but never used                                                         unused-imports/no-unused-vars
Error:   50:52  error  'currentStatus' is assigned a value but never used. Allowed unused args must match /^_/u  unused-imports/no-unused-vars
Error:   63:11  error  'data' is assigned a value but never used. Allowed unused vars must match /^_/u           unused-imports/no-unused-vars

/pages/manage/statuses.vue
Error:   26:15  error  'refresh' is assigned a value but never used. Allowed unused vars must match /^_/u  unused-imports/no-unused-vars
Error:   71:60  error  This 'v-if' should be moved to the wrapper element                                  vue/no-use-v-if-with-v-for

/utils/update-classroom-data.ts
Error:   30:1  error  Do not use top-level await  antfu/no-top-level-await
changeset-bot[bot] commented 1 month ago

šŸ¦‹ Changeset detected

Latest commit: ee0989d888ebd47319b72090c603f838dbd82c9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | enspire | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 month ago

Deploy Preview for enspire-staging ready!

Name Link
Latest commit ee0989d888ebd47319b72090c603f838dbd82c9a
Latest deploy log https://app.netlify.com/sites/enspire-staging/deploys/6714cfd36712dd0008f7c1d3
Deploy Preview https://deploy-preview-637--enspire-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

at-wr commented 1 month ago

Conclusion, add underscore "_" before unused vars to avoid the ESLint warning.

qwerzl commented 4 weeks ago

Conclusion, add underscore "_" before unused vars to avoid the ESLint warning.

I'd recommend just deleting the vars.