Closed vivyir closed 1 year ago
Splendid work! I genuinely appreciate the effort you put into making such a well-written PR! :heart:
I'm a bit busy at work now, but I'll arrange the proper time and attention to review your PR as soon as possible.
Edit: I authorized the CI workflows to run, and it looks like Clippy outputted some warnings. You could take care of them in the meantime to save on reviews!
Restructured the project according to the resources you provided, unfortunately I got carried away and put everything into one massive commit, but below is a relatively accurate summary of everything that was changed (copied verbatim from the commit message with slight edits), please have a look over the code aswell, I'd love any feedback you may have, thanks!
Notes:
Edits:
assume_init
function had to be made: "assume_init_box
" (in common.rs)OggPacket
to make stuff cleanerVorbisInfo
's (in common/vorbis_data.rs:20-21) field was made publicVorbisComments
's (in common/vorbis_data.rs:196-197) field was made publicVorbisEncodingState
's (encoder/encoder_data.rs:13-18) fields were made public.assume_init()
being used on Box objects were replaced with calls to the new "assume_init_box
" function