ConEmu / old-issues

Old issues for ConEmu project (import is pending)
http://conemu.github.io/
0 stars 1 forks source link

Title word skipping does not handle command in parantheses correctly #1121

Closed ConEmu closed 9 years ago

ConEmu commented 9 years ago

From pfeif...@tzi.de on June 26, 2013 09:38:09

Required information! OS version: Windows 7 Ultimate, 64 bit, SP1, German ConEmu version: ConEmu 130625 [64] Bug description I add C:\Windows\System32\ as token to the word list for title skipping.

But there are some command lines that are started/shown in parantheses (example: "C:\Windows\System32\cmd.exe") and these tabs are not re-formatted (see red circles in screenshot).

Furthermore the skipping feature isn't applied to the window title (see blue circles in screenshot).

Attachment: Screenshot.png

Original issue: http://code.google.com/p/conemu-maximus5/issues/detail?id=1122

ConEmu commented 9 years ago

From pfeif...@tzi.de on June 26, 2013 10:13:33

BTW: The consoles in parantheses were started by executing cmd.exe via WIN+R run dialog.

ConEmu commented 9 years ago

From pfeif...@tzi.de on June 26, 2013 10:17:08

I would recommend to always skip leading and trailing whitespaces as well as parantheses from the console title.

ConEmu commented 9 years ago

From pfeif...@tzi.de on July 04, 2013 00:33:08

Instead of skipping they may should be better ignored for string prefix comparision.

ConEmu commented 9 years ago

From pfeif...@tzi.de on August 01, 2013 07:47:04

Sometimes I have unexpected parantheses in the title (depending on how the console was started).

Attachment: ConEmu-Broken-Title.png

ConEmu commented 9 years ago

From pfeif...@tzi.de on September 18, 2013 02:38:58

FYI: I just verified that this issue is still there in version 130917[64].

ConEmu commented 9 years ago

From ConEmu.M...@gmail.com on September 18, 2013 07:27:29

Attach your ConEmu .xml please

ConEmu commented 9 years ago

From pfeif...@tzi.de on September 18, 2013 07:35:36

Here it is ...

Attachment: ConEmu.xml

ConEmu commented 9 years ago

From ConEmu.M...@gmail.com on September 18, 2013 07:49:16

This option is case sensitive.

ConEmu commented 9 years ago

From pfeif...@tzi.de on September 18, 2013 08:13:44

Yes I know, but I enter "C:\Windows\System32\" with correct case (see my attached configuration).

I assume that it depends on these parantheses that appears in the beginning and the end?

ConEmu commented 9 years ago

From pfeif...@tzi.de on September 18, 2013 08:23:07

I propose to trim all leading / trailing parantheses and whitespaces in general. Obviously the word skipping algorithm has to be applied afterwards.

ConEmu commented 9 years ago

From ConEmu.M...@gmail.com on September 18, 2013 08:34:20

You set "System" in field but tab has "system" word. Actually, it is not "word" but any "string" skipping option. Also, I'll make it case insensitive in next build.

BTW, parenthesis are '(' and ')' symbols, but not a quotation marks.

ConEmu commented 9 years ago

From pfeif...@tzi.de on September 18, 2013 08:39:32

Hmm, my field for word skipping looks as follows (see attached screenshot).

Sorry for the mistake of using the wrong word. Obviously I assume to trim all "quotation marks" and whitespaces before skipping/removing the words.

To be honest I would prefer if ConEmu generally removes all leading/trailing quotations marks and whitespaced independently of the skipping feature.

Attachment: Screenshot.png

ConEmu commented 9 years ago

From ConEmu.M...@gmail.com on September 18, 2013 08:53:58

Your screenshot confirmed that

You set "System32" in field, but tab has "system32"

Skipping all quotation marks is illegal. For example "C:...\cmd.exe" /c "ping www.www.com" Quotations in the middle will be weird.

BTW, why you don't use "%n" instead of "%s" in tab template?

ConEmu commented 9 years ago

From pfeif...@tzi.de on September 18, 2013 09:19:15

Ah ok now I get it. Thank you very very much.

What's about the single trailing quotation mark as shown in this screenshot? http://conemu-maximus5.googlecode.com/issues/attachment?aid=11220004000&name=ConEmu-Broken-Title.png&token=pouim8hzBpSRXpqaRxQ9fJGi2xE%3A1379520977853&inline=1 BTW: Does skipping algorithm ignore quotation marks?

ConEmu commented 9 years ago

From ConEmu.M...@gmail.com on September 24, 2013 04:12:16

Skipping algorithm ignores all symbols which differs from "skip string". Current build use case insensitive search.

Status: Fixed

ConEmu commented 9 years ago

From pfeif...@tzi.de on September 25, 2013 05:01:21

Works fine now but the title is still showing some weird quotation marks.

Looks as shown in this screenshot: http://conemu-maximus5.googlecode.com/issues/attachment?aid=11220004000&name=ConEmu-Broken-Title.png&token=ECeoxeJwymEneAoZ03ppUMgKY_0%3A1380110365278&inline=1

ConEmu commented 9 years ago

From ConEmu.M...@gmail.com on September 25, 2013 05:26:49

Quotation marks are the subject of another issue about "Default terminal" feature. Issue exists, no need to create new one. Wait for the patch.