search

ConSol-Monitoring / omd

OMD - Open Monitoring Distribution Labs Edition.
http://omd.consol.de
GNU General Public License v2.0
171 stars 35 forks source link

check_dns 2.3.3 (bundled with 5.20) misses option -q while RPM version 2.3.3 has it included #174

Open pbiering opened 11 months ago

pbiering commented 11 months ago

Is there a packaging/bundling problem?

check_dns reports same version, but has different features, the OMD one looks like from 2008 while the RPM based one is from 2018

OMD 5.20:

/opt/omd/versions/default/lib/monitoring-plugins/check_dns -h
check_dns v2.3.3 (monitoring-plugins 2.3.3)
Copyright (c) 1999 Ethan Galstad <nagios@nagios.org>
Copyright (c) 2000-2008 Monitoring Plugins Development Team
        <devel@monitoring-plugins.org>
...

(missing option -q)

while from RPM nagios-plugins-dns-2.3.3-6.el8.x86_64:

/usr/lib64/nagios/plugins/check_dns -h
check_dns v2.3.3 (nagios-plugins 2.3.3)
Copyright (c) 1999 Ethan Galstad <nagios@nagios.org>
Copyright (c) 2000-2018 Nagios Plugin Development Team
...
 -q, --querytype=TYPE
    Optional DNS record query type where TYPE =(A, AAAA, SRV, TXT, MX, ANY)
    The default query type is 'A' (IPv4 host entry)
    BIND 9.11.x onwards supports both 'A' and 'AAAA', if you want both use 'ANY'
...
sni commented 11 months ago

OMD ships the https://www.monitoring-plugins.org/ while rhel uses nagios-plugins. Both projects having the same version is only a coincidence and might happen, since both share the same roots.

pbiering commented 11 months ago

Looks like related to https://github.com/monitoring-plugins/monitoring-plugins/issues/894, while check_dns from Nagios plugins was extended, Monitoring plugins refer to use check_dig as replacement.

So I see some options

  1. clearly mark check_dns as deprecated in OMD / Monitoring plugins
  2. merge from Nagios plugins to be back on equal feature level even it should be phased out
pbiering commented 11 months ago

During evaluation/migration it turned out that check_dns cannot be 100% replaced by check_dig