search

ConSol-Monitoring / snclient

SNClient+ - Cross platform monitoring agent
MIT License
47 stars 9 forks source link

misleading "client certificates" configuration option #104

Closed Gent00157 closed 3 months ago

Gent00157 commented 4 months ago

Hi again, I checked how client cert auth. is implemented in snclient and it seems to be OK, only thing what was not clear to me is how to enable it. It can be enabled using client certificates configuration option in snclient, which is a little bit misleading as it should contains CA certificate(s). In original NSCP, it can be enabled using ca and verify mode options. I'd suggest add this options (and remove client certificates) into the snclient for backward compatibility - what do you think?

PS: thanks for "fixing" CheckExternalScripts

sni commented 4 months ago

feel free to improve the documentation. Also do not remove options, but feel free to add ca and verify mode to make it more backwards compatible.

Gent00157 commented 4 months ago

Oki, thanks, I will do ;)

Gent00157 commented 3 months ago

Hey, I updated ca option and security doc, so merge it if you want, or let me know if you realize any problem ;)

sni commented 3 months ago

thanks, i'll have a look

sni commented 3 months ago

merged it, thanks

Gent00157 commented 3 months ago

You are welcome, thanks as well ;)