search

ConSol-Monitoring / snclient

SNClient+ - Cross platform monitoring agent
MIT License
47 stars 9 forks source link

Client certificate backward compatibility #108

Closed Gent00157 closed 3 months ago

Gent00157 commented 3 months ago

Added ca option for backward compatibility with NScilent when using client certificate auth. and doc. update.

sni commented 3 months ago

looks good, next time please run gofmt on the code to make sure it fits the code style of the other files. Also I'd say it would be cleaner to make the ca files a list from the start instead of appending them to a comma separated string to split it a couple of lines later. But that's something i can do. So thank you very much, i'll take it from here.

sni commented 3 months ago

i pushed the PR manually, thanks again.