Check_OS_Version in 0.25 not pulling OS Build Number

ConSol-Monitoring / snclient

SNClient+ - Cross platform monitoring agent

MIT License

48 stars 8 forks source link

Check_OS_Version in 0.25 not pulling OS Build Number #134

Closed q2uantum closed 2 months ago

q2uantum commented 2 months ago

Previous to 0.25 - we would get the following when doing Check_OS_Version:

OK - Microsoft Windows Server 2019 Standard 10.0.17763.6054 Build 17763.6054 (arch: amd64)

0.25 now reports back this:

OK - Microsoft Windows Server 2019 Standard (arch: amd64)

Build version is useful to us and is used when doing checks on servers to see if they are fully patched with updates, as build number changes when patched.

Using SNLCIENT with Nagios Core 4.5.3

alexoalexo commented 2 months ago

I've just noticed the same, right after upgrading today.

sni commented 2 months ago

reported upstream: https://github.com/shirou/gopsutil/issues/1666#issuecomment-2222538893

davidnewhall commented 2 months ago

No you didn't. Someone asked for a feature in Linux, and you left a comment about Windows that doesn't even make sense. That wasn't a report by any means, and you should just go delete your comment.

davidnewhall commented 2 months ago

The actual problem with a workaround: https://github.com/shirou/gopsutil/pull/1629