search

ConaireD / TolimanWIP

WIP Toliman codes go here before being added to the main TOLIMAN github
Other
0 stars 0 forks source link

Implement `read_csv_to_array`. #29

Closed Jordan-Dennis closed 1 year ago

Jordan-Dennis commented 1 year ago

Hi all, I have repeated logic when it comes to reading the csv assets (not committed until #1 is resolved). This is just a personal reminder to write this as a function with better error handling (see #4). Regards Jordan.

Jordan-Dennis commented 1 year ago

So I tested the more jaxified approach (i.e. using tree_map) against the list comprehension and it loses slightly. I'm going to stick with it since performance is not so important here. This code cannot be compiled by jax (without assuming max length) so there is no advantage to using jax over regular python.

Jordan-Dennis commented 1 year ago

Actually, my previous comment is mistaken as there was an extra strip in the methods I was comparing.

Jordan-Dennis commented 1 year ago

It is possible to beat the performance of both using map from python, but I think that is enough time wasted on this.