search

ConaireD / TolimanWIP

WIP Toliman codes go here before being added to the main TOLIMAN github
Other
0 stars 0 forks source link

Implement `GeometricAberration`. #30

Open Jordan-Dennis opened 1 year ago

Jordan-Dennis commented 1 year ago

Hi all, We need to implement a layer to handle the geometric aberrations (if this is a good name for them) on the secondary mirror. @ConaireD hacked together a nice solution, but I want to look into the raytracing module that @Jashcraf and see if we can't use that as a more sophistocated solution. This is a long term goal and it is not immediately needed. Regards Jordan.

Jashcraf commented 1 year ago

Hiya @Jordan-Dennis

Poke (my raytracing module) would be a really good solution if you want to directly integrate a Zemax / CODE V as a geometric aberration layer! I'm quite certain we can generate a cumulative optical path map at a given surface and just add that as a layer.

I will say that the best place for such a layer would be at a pupil plane, where the wavefront has little-to-no curvature. If you want to drop a convex mirror in the middle of a paraxial diffraction model, then Poke might not work so well.

ConaireD commented 1 year ago

Hi @Jordan-Dennis - I believe the correct name is "mid-spatial" errors. However, I refer them to them as secondary mirror aberrations.

I am not sure if we need a raytracing model - Peter and Chris seemed satisfied with my hacky solution. Raytracing would be more accurate however there is issues with speed/ computational cost. Not sure if raytracing can be made faster but this seems like it should be brought up in a bigger TOLIMAN meeting - whenever they kick into gear.

And FYI I think SAIL tends to use Zemax over CODE V. Atleast TOLIMAN does.