search

Conal-Tuohy / VMCP-upconversion

Ferdinand von Mueller's correspondence upconversion from MS Word to TEI XML
Apache License 2.0
3 stars 2 forks source link

Detecting addressee in letters in Mentions folders #42

Closed LucasHorseshoeBend closed 3 years ago

LucasHorseshoeBend commented 6 years ago

For when you get funds: Example file: http://vmcp.conaltuohy.com/xtf/view?docId=tei/Mentions/Selected Mentions letters/M52-10-08-final.xml I noticed a problem with mentions letters coming up with Mueller as the author; we fixed it by starting the correspondent line with From. The Author facet now helpfully shows up as, for example, "Charles La Trobe to Ronald Gunn". But the Addressee facet for these files shows "Ferdinand von Mueller".

I suspect that the algorithm needs to be tweaked to check for to in the text of the correspondent style, so that the part of it after to is identified as the Addressee. It would be a pity to lose the current identification of correspondent for these files which shows up everything after From, but if we have to, then it's a price I think worth paying to prevent Mueller being the default Addressee.

Conal-Tuohy commented 3 years ago

this has been done, and should've been closed a while ago

LucasHorseshoeBend commented 3 years ago

Conal, I'll respond to your other queries ASAP, but it might be tomorrow.

Best wishes Arthur

On 17 Feb 2021, at 06:28, Conal Tuohy notifications@github.com wrote:

Closed #42 https://github.com/Conal-Tuohy/VMCP-upconversion/issues/42.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Conal-Tuohy/VMCP-upconversion/issues/42#event-4339677151, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3IGTX6HDQA7R2EO4VL6EDS7NOXBANCNFSM4EJBF3KA.