weijia-cheng commented 1 year ago

Typography

[x] typogrify removes word joiners in your long description, which I think you should accept.
[x] the-isle-of-pines.xhtml: You have an instance of <i>[sic]</i>.

Spelling

[x] modernize-spelling changes sheweth to showeth, which I think you should accept. I see that it’s in the context of a “quote” but they are both archaic sound-alikes and it doesn’t make sense to me that in our corpus we would change shew to show but not sheweth to showeth.
[ ] 2816274f714b72475023184ddee08ee1d6d98b53: Are you sure these are sound-alikes? I can’t seem to find a source on the pronunciation of “madroño” but it seems like it would be closer to the Spanish pronunciation than “madrone.”
[x] Maybe double-check with Alex, but I think we should modernize “sirup” to “syrup” even though it is in the title.

Semantics

[x] Seems like the “For there be divers sorts of death...” quote at the start of “An Inhabitant of Carcosa” can marked up as an epigraph.
[x] The sections of “A Resumed Identity” should be chapters and not divisions.
[x] Ditto with “The Damned Thing,” “The Middle Toe of the Right Foot,” “The Moonlit Road,” “The Realm of the Unreal,” and “The Haunted Valley.”
[x] “The Death of Halpin Frayser” lacks semantics on the sections entirely.

Commit History

[x] 4f9c387f99f3ebf4128515dbbd32bdd0d0d8ad17 should be Editorial.

Metadata

[x] http://www.ambrosebierce.org/works.html seems to be dead. It returns a 500 error. Should we link to a Wayback Machine snapshot?

Comments

72137854eb1e984e7d03f83afd56ac3b9fa22c96: I don’t think that it is wrong, per se, to insert those <time> semantics, but it seems excessive and not really necessary. Generally, I wouldn’t put <time>s in normal running text (though again, it isn’t wrong to do so).

ConcaveTrillion commented 1 year ago

Corrected Typography items.
Modernized sheweth and sirup. As for madroño, I just used MW's entry, which indicated two variant spellings, madrona and madrono. I can revert if you'd prefer.
Correct Semantic Issues
Rebased and added editorial to 3d > 3rd.
I can't believe the site disappeared! This must've just recently happened. I updated to the wayback machine snapshot.
As for <time>, I like it at least on years because they're often pronounced differently than numbers, and I'm not sure a screen reader always pronounces them in the typical two-digit x2 method ("nineteen ten") - not that most do it right anyway, but maybe someday. I reverted it so that all that's left is on years.

Please let me know your thoughts on madroño and the remaining items, and if everything else looks good.

ConcaveTrillion commented 1 year ago

I discovered when I corrected the epigraph in "Caracosa" I neglected to wrap it in <header> elements. That's been pushed. I also added links to the SE collections of Poe and Maupassant in the quote in the long description.