ConchordanceProject / ConchordanceWeb

A webapp for exploring chord fingerings for any fretted instrument.
4 stars 0 forks source link

Moved client files to /client #70

Closed alexnsolo closed 9 years ago

jbauschatz commented 9 years ago

@civilframe how is it if we leave index.html in the root folder for now? I don't know how to point the github pages into the client folder yet...

alexnsolo commented 9 years ago

Well, then express would have to serve up the entire root folder, putting us back to square one. How about we hold off merging until we can setup a different hosting solution that uses express?

forana commented 9 years ago

(philosophy tangent: .gitignore signals to other developers "these are files that I never ever want to see in this repo")

forana commented 9 years ago

Temporary to get around the gh-pages thing: http://en.wikipedia.org/wiki/Meta_refresh

jbauschatz commented 9 years ago

Sure. The reason I thought to keep it out is that if each developer uses different IDE the .gitignore becomes flooded with everybody's project files and such. Seems like it could become a mess, and less of a "signal". But I get it.

On Mon, Oct 20, 2014 at 9:36 AM, forana notifications@github.com wrote:

(philosophy tangent: .gitignore signals to other developers "these are files that I never ever want to see in this repo")

— Reply to this email directly or view it on GitHub https://github.com/ConchordanceProject/ConchordanceWeb/pull/70#issuecomment-59767353 .

Sláinte Mhath, John Charles

forana commented 9 years ago

java default doesn't include IDE files: https://github.com/github/gitignore/blob/master/Java.gitignore

(I usually include them, but I'm very guilty of using .gitignore instead of --assume-unchanged because it's easier :smile: )

jbauschatz commented 9 years ago

I think I understand the standard now. The .gitignore includes project-generated artifacts but not external files. Developer's are responsible for keeping their own .project/etc out using the --assume-unchanged.

alexnsolo commented 9 years ago

This PR is now obsolete by the "Log in, log out" one.