search

Concorda / concorda-dashboard

concorda dashboard
MIT License
5 stars 8 forks source link

Forms validation #62

Closed ckiss closed 8 years ago

ckiss commented 8 years ago

@mcdonnelldean have you done any research on this? what should we use for forms validations?

mcdonnelldean commented 8 years ago

For now just enough to not allow complete garbage, do it in the component itself. We can look at something fancy down the road.

salmanm commented 8 years ago

https://github.com/erikras/redux-form is pretty useful but painfully slow. We can try it though, newer version could be faster. Let me know if I can jump in.

ckiss commented 8 years ago

@mcdonnelldean I would like to use something right from the beginning so we don't have to revisit this in the future. What do you think about @salmanm suggestion? I like this from it too: Initializing From State. @salmanm of course you can jump in :) have you used this in the past? The functionality it offers seems pretty tempting.

ckiss commented 8 years ago

@salmanm I looked at the client-side validation http://erikras.github.io/redux-form/#/examples/synchronous-validation?_k=arlsuk and wrt speed it looks good to me

salmanm commented 8 years ago

Yes I've used it and found it to be great. It automatically binds all the handlers and keeps the state in sync. Gives a nice way to handle async validations as well. On Jan 26, 2016 19:03, "Cristian Kiss" notifications@github.com wrote:

@mcdonnelldean https://github.com/mcdonnelldean I would like to use something right from the beginning so we don't have to revisit this in the future. What do you think about @salmanm https://github.com/salmanm suggestion? I like this from it too: Initializing From State. @salmanm https://github.com/salmanm of course you can jump in :) have you used this in the past? The functionality it offers seems pretty tempting.

— Reply to this email directly or view it on GitHub https://github.com/nearform/concorda/issues/62#issuecomment-175013248.

ckiss commented 8 years ago

nice, thanks. I think I'm going to use it. do you have anything against this @mcdonnelldean? :D

salmanm commented 8 years ago

Yes, may be, I used a couple of months ago, and it was slow, I even doubt that it's not the redux-form that is slow, it could be the rapid state change and keeping Redux DevTools open makes it slow On Jan 26, 2016 7:04 PM, "Salman Mitha" salmanmitha@gmail.com wrote:

Yes I've used it and found it to be great. It automatically binds all the handlers and keeps the state in sync. Gives a nice way to handle async validations as well. On Jan 26, 2016 19:03, "Cristian Kiss" notifications@github.com wrote:

@mcdonnelldean https://github.com/mcdonnelldean I would like to use something right from the beginning so we don't have to revisit this in the future. What do you think about @salmanm https://github.com/salmanm suggestion? I like this from it too: Initializing From State. @salmanm https://github.com/salmanm of course you can jump in :) have you used this in the past? The functionality it offers seems pretty tempting.

— Reply to this email directly or view it on GitHub https://github.com/nearform/concorda/issues/62#issuecomment-175013248.

ckiss commented 8 years ago

cool, thanks @salmanm :D

mcdonnelldean commented 8 years ago

Lets bring it in and see how it looks, if it's slow I'll pull it out but if it works lets use it.