search

Concorda / concorda-dashboard

concorda dashboard
MIT License
5 stars 8 forks source link

User cannot change their password #67

Closed shanel262 closed 8 years ago

shanel262 commented 8 years ago

When the user selects to edit an account, only the name and email can be changed and not the password.

mcdonnelldean commented 8 years ago

@ckiss @mirceaalexandru This should be allowed in Concorda (but not Vidi). @ckiss Assigned to you.

mirceaalexandru commented 8 years ago

To change a password the request should contain both password && repeat fields, with identical values.

If no password should be changed then these fields should be missing or empty in the request body for update user.

mirceaalexandru commented 8 years ago

@ckiss an old bug in seneca-user...

mcdonnelldean commented 8 years ago

@ckiss Is this done? There's a merge ref above

ckiss commented 8 years ago

@mcdonnelldean yup, but we found a bug in seneca-user which will be fixed today. I'll let Mircea close this after he fixes the issue

mcdonnelldean commented 8 years ago

Awesome stuff :dancer:

mirceaalexandru commented 8 years ago

fixed by

https://github.com/senecajs/seneca-user/pull/33

I will close it after seneca-user's PR is merged.

mirceaalexandru commented 8 years ago

tested and working