Closed target-san closed 1 year ago
Hi, thank you for your contribution 🙌
I just want to inform you that we've moved the libraries to https://github.com/Concordium/concordium-base/tree/main/smart-contracts/contracts-common as there are no longer any repositories that have contracts-common as a direct submodule.
If you want to finish up the work you've started and get it reviewed, then please open a new PR against the concordium-base repository I've linked above and add two of the core-contributors (fx me and one more) as reviewers. Also, it would be great if you opened an issue before starting the work. Then we can discuss the approach with you, and it will be much more likely for your work to be merged. 😊
Have a great day, and again thank you for your contribution and interest!
Oops, sorry, forgot about this one - it's completely broken due to submodule merge conflicts. Please just ignore.
Okay, fair enough. Have a nice day :-)
Purpose
Make procedural macros, including derives, compile correctly without importing any symbols into scope. Intended to remove need for wildcard imports, increase usage clarity and reduce probability of conflicts.
Changes
Procedural macros now generate symbol references using full explicit paths. This includes standard types like
Result
orDefault
derive(Serial)
derive(Deserial)
derive(DeserialWithState)
derive(Deletable)
derive(SchemaType)
derive(Reject)
init
receive
Checklist
CLA acceptance
By submitting the contribution I accept the terms and conditions of the Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
[x] I accept the above linked CLA.