Concordium / concordium-dapp-examples

Place to put small dApp examples
Mozilla Public License 2.0
8 stars 15 forks source link

Add release actions for dApp examples #70

Closed lassemoldrup closed 6 months ago

lassemoldrup commented 7 months ago

Purpose

Closes #69.

Closes #78

Checklist

abizjak commented 6 months ago

This is a research question and can be done in a different PR/issue:

Currently, if someone accidentally wrongly tags this repo e.g. euroe-demo/0.0.0, this release pipeline is triggered. The release pipeline would look up the correct version and publish it to docker hub. Nonetheless, to not rely on the reviewer/approver of the release pipeline to check for a version mismatch, it would be nice if the release action could check (when it was triggered via a tag) that the versions match.

Yes, this is correct, but it's also one of those things where having this check adds extra complexity and problems. So I don't think this is really necessary for now. It's a nice to have that we can live without.

DOBEN commented 6 months ago

This is a research question and can be done in a different PR/issue: Currently, if someone accidentally wrongly tags this repo e.g. euroe-demo/0.0.0, this release pipeline is triggered. The release pipeline would look up the correct version and publish it to docker hub. Nonetheless, to not rely on the reviewer/approver of the release pipeline to check for a version mismatch, it would be nice if the release action could check (when it was triggered via a tag) that the versions match.

Yes, this is correct, but it's also one of those things where having this check adds extra complexity and problems. So I don't think this is really necessary for now. It's a nice to have that we can live without.

We can create an issue for future research in the backlog. https://github.com/Concordium/concordium-dapp-examples/issues/78