search

Concordium / concordium-dapp-libraries

A coherent set of building blocks for making it as easy as possible for developers to build web-based dApps.
Apache License 2.0
7 stars 5 forks source link

Add sample dApp 'sign-message' #29

Closed bisgardo closed 1 year ago

bisgardo commented 1 year ago

Add a rewrite of the current signMessage dApp that uses the libraries and add it as a sample. The rewrite simplifies the dApp and helps testing the signMessage call.

It's likely that the dApp will be removed (or replacing the example one linked above) once we have the proper test coverage to have it not needing to be here anymore.

bisgardo commented 1 year ago

I don't think we should move/duplicate the sample to here. If you want to make it use this library, then please make a PR for it in its current repo.

@shjortConcordium I would like to have sample coverage of the features implemented in the library, within the repo. It makes it much easier to test changes.

sign-message is not a proper example dapp as it only does one thing that's clearly intended for testing. I think the examples should be showcasing something interesting rather than trivial test stuff.

It would make sense to me to simplify the contract-upgrade sample dapp and move the current impl to the examples repo, because it does more than what's necessary to test the libs. But that's for another PR :)