search

Concordium / concordium-dapp-libraries

A coherent set of building blocks for making it as easy as possible for developers to build web-based dApps.
Apache License 2.0
7 stars 5 forks source link

wallet-connectors: Add docstrings #3

Closed bisgardo closed 1 year ago

bisgardo commented 1 year ago

Document all exported types, fields, etc. of the wallet-connection library.

bisgardo commented 1 year ago

@shjortConcordium @soerenbf Not sure why I cannot set you both as reviewers. I remember seeing it before, but cannot find the settings to change. It's probably because the repo is still private.

soerenbf commented 1 year ago

@shjortConcordium @soerenbf Not sure why I cannot set you both as reviewers. I remember seeing it before, but cannot find the settings to change. It's probably because the repo is still private.

Yes, weird.. we were both on the other PR in this repo, so it confuses me a little as well :stuck_out_tongue_closed_eyes:

bisgardo commented 1 year ago

@shjortConcordium @soerenbf Not sure why I cannot set you both as reviewers. I remember seeing it before, but cannot find the settings to change. It's probably because the repo is still private.

Yes, weird.. we were both on the other PR in this repo, so it confuses me a little as well stuck_out_tongue_closed_eyes

No it removed the first reviewer when I added the second. I just tagged you both.

bisgardo commented 1 year ago

A readme.md would also be nice, but might be out of scope of this PR.

https://github.com/Concordium/concordium-dapp-libraries/pull/5