search

Concordium / concordium-dapp-libraries

A coherent set of building blocks for making it as easy as possible for developers to build web-based dApps.
Apache License 2.0
7 stars 5 forks source link

wallet-connectors: WalletConnect: Use "lower" camelCase format for transaction type #42

Closed bisgardo closed 10 months ago

bisgardo commented 12 months ago

This apparently is the standard style used for these strings. This is achieved by using the new function getTransactionKindString in @concordium/common-sdk@9.0.0. We use a yarn resolution to override the version specified by @concordium/browser-wallet-api-helpers (https://github.com/Concordium/concordium-browser-wallet/pull/324 suggests reducing this dependency to a "peer dependency").

This doesn't change anything in the Android wallet as it doesn't read the field but just assumes that it's an update transaction. The iOS implementation reads the field and supports both formats for backwards compatibility with projects using old versions of @concordium/wallet-connectors. The Android implementation must do the same when it starts supporting other transaction types.

Resolves CBW-1145.

bisgardo commented 12 months ago

SDK fix: https://github.com/Concordium/concordium-node-sdk-js/pull/220. Will use this instead once released.

bisgardo commented 11 months ago

SDK fix: Concordium/concordium-node-sdk-js#220. Will use this instead once released.

Done.

bisgardo commented 10 months ago

Ping @shjortConcordium @orhoj.